Skip to content

Commit

Permalink
Do not set compiler to mingw32 on Windows (#5)
Browse files Browse the repository at this point in the history
With this patch, msvc is used, which is the default for building
Python extensions on Windows.
Currently, one must force usage of msvc when building bdist_wheel and
installing with something like:

%PYTHON% -m pip install . -vv --global-option build --global-option
--compiler=msvc --global-option build --global-option --cythonize

This kind of command will no longer work in the next major release of
pip: pypa/pip#8368
  • Loading branch information
tschoonj authored Sep 13, 2020
1 parent bb5c150 commit 983ad77
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions setuptools_cythonize.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ def initialize_options(self):
def finalize_options(self):
build.finalize_options(self)

if not self.compiler and platform.system() == 'Windows':
log.warn("No compiler provided, set it to mingw32 as default")
self.compiler = 'mingw32'


class CythonizeBuildPy(build_py):

Expand Down

0 comments on commit 983ad77

Please sign in to comment.