Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster add, etc. #85

Merged
merged 5 commits into from
Nov 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tidy up
anzdaddy committed Nov 28, 2024
commit c8da0b2f054a1d57eea34412154a459c15e47903
2 changes: 1 addition & 1 deletion decimal64math_test.go
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@
x := MustParse64(a)
y := MustParse64(b)
replayOnFail(t, func() {
z := cmp.Or(ctx, &DefaultContext64).Add(x, y)

Check failure on line 61 in decimal64math_test.go

GitHub Actions / Build

undefined: cmp.Or
equalD64(t, e, z)
})
}
@@ -67,7 +67,7 @@
t.Run("tiny-neg", add("1E-383", "-1E-398", "9.99999999999999E-384", nil))

he := Context64{Rounding: HalfEven}
t.Run("round-even", add("12345678", "0.1234567850000000", "12345678.12345678", &he))
t.Run("round-even", add("12345678", "0.123456785", "12345678.12345678", &he))
}

func TestDecimal64AddNaN(t *testing.T) {

Unchanged files with check annotations Beta

}
// separation gets the separation in decimal places of the MSD's of two decimal 64s
func (dp *decParts) separationV2(ep *decParts) int16 {

Check failure on line 115 in decimal64decParts.go

GitHub Actions / golangci

[golangci] decimal64decParts.go#L115

func `(*decParts).separationV2` is unused (unused)
Raw output
decimal64decParts.go:115:21: func `(*decParts).separationV2` is unused (unused)
func (dp *decParts) separationV2(ep *decParts) int16 {
                    ^
sep := int16(numDecimalDigitsU64(dp.significand.lo)) + dp.exp
sep -= int16(numDecimalDigitsU64(ep.significand.lo)) + ep.exp
return sep