v1.18: Fix: decayed_counter can overflow if shifted more than 63 (bac…

…kport of solana-labs#35054) (solana-labs#35057)

Fix: decayed_counter can overflow if shifted more than 63 (solana-labs#35054)

(cherry picked from commit bf95f65)

Co-authored-by: Pankaj Garg <[email protected]>

program-runtime/src/loaded_programs.rs

@@ -444,7 +444,8 @@ impl LoadedProgram {
 
     pub fn decayed_usage_counter(&self, now: Slot) -> u64 {
         let last_access = self.latest_access_slot.load(Ordering::Relaxed);
-        let decaying_for = now.saturating_sub(last_access);
+        // Shifting the u64 value for more than 63 will cause an overflow.
+        let decaying_for = std::cmp::min(63, now.saturating_sub(last_access));
         self.tx_usage_counter.load(Ordering::Relaxed) >> decaying_for
     }
 }
@@ -1308,6 +1309,10 @@ mod tests {
         assert_eq!(program.decayed_usage_counter(19), 16);
         assert_eq!(program.decayed_usage_counter(20), 8);
         assert_eq!(program.decayed_usage_counter(21), 4);
+
+        // Decay for 63 or more slots
+        assert_eq!(program.decayed_usage_counter(18 + 63), 0);
+        assert_eq!(program.decayed_usage_counter(100), 0);
     }
 
     #[test]