relax stake split destination check

[Nagaprasadvr]

Issue #147

####Improvements

1. Removed strict checks for staked_split_account and allowed account owned by system program with no data and some lamports to be allocated as a new stake account to receive stake split

Summary of Changes

1 solana/cli/src/stake.rs
function - process_split_stake
removed some strict checks resulting in allowing system account (without data and some lamports) to be allocated as new stake account to receive split

[CriesofCarrots]

Thanks! The logic looks correct now.
One nit to add a comment to help elucidate the nested ifs. Then I think this is good, as long as CI is happy.

Also, in future, please don't push merge commits. We much prefer rebase and force push to pick up latest upstream.

[Nagaprasadvr]

Thanks! The logic looks correct now. One nit to add a comment to help elucidate the nested ifs. Then I think this is good, as long as CI is happy.

Also, in future, please don't push merge commits. We much prefer rebase and force push to pick up latest upstream.

sure !

[CriesofCarrots]

Thank you! Will merge once CI passes (macos clippy failures are unrelated)

[Nagaprasadvr]

Thank you! Will merge once CI passes (macos clippy failures are unrelated)

ty

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (72d6d78) to head (83232e4).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage    81.8%    81.9%           
=======================================
  Files         837      837           
  Lines      226741   226743    +2     
=======================================
+ Hits       185699   185732   +33     
+ Misses      41042    41011   -31     

[CriesofCarrots]

Thanks for your contribution @Nagaprasadvr

[CriesofCarrots]

Merging on red, as CI failures are unrelated

[Nagaprasadvr]

Thanks for your contribution @Nagaprasadvr

🙌

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.