Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: vote: deprecate unused legacy vote tx plumbing (backport of #274) #276

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 16, 2024

start cleaning up some plumbing


This is an automatic backport of pull request #274 done by [Mergify](https://mergify.com).

(cherry picked from commit b27c80a)

# Conflicts:
#	sdk/src/feature_set.rs
Copy link
Author

mergify bot commented Mar 16, 2024

Cherry-pick of b27c80a has failed:

On branch mergify/bp/v1.18/pr-274
Your branch is up to date with 'origin/v1.18'.

You are currently cherry-picking commit b27c80a920.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   programs/vote/benches/process_vote.rs
	modified:   programs/vote/src/vote_state/mod.rs
	modified:   sdk/program/src/vote/state/mod.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdk/src/feature_set.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@AshwinSekar AshwinSekar requested a review from carllin March 16, 2024 05:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (04356e7) to head (e7712bd).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.18     #276     +/-   ##
=========================================
+ Coverage    80.6%    81.6%   +1.0%     
=========================================
  Files         827      827             
  Lines      224496   224515     +19     
=========================================
+ Hits       181015   183289   +2274     
+ Misses      43481    41226   -2255     

Copy link

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for backport to beta

@willhickey willhickey merged commit 6c4fb98 into v1.18 Mar 18, 2024
34 checks passed
@willhickey willhickey deleted the mergify/bp/v1.18/pr-274 branch March 18, 2024 03:16
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…za-xyz#274) (anza-xyz#276)

* vote: deprecate unused legacy vote tx plumbing (anza-xyz#274)

(cherry picked from commit b27c80a)

# Conflicts:
#	sdk/src/feature_set.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants