Move code to check_program_modification_slot out of SVM #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
previously approved these changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 837 837
Lines 226874 226873 -1
=========================================
- Hits 185868 185835 -33
- Misses 41006 41038 +32 |
dmakarov
approved these changes
Mar 20, 2024
LucasSte
reviewed
Mar 20, 2024
Comment on lines
+107
to
+109
| fn get_program_match_criteria(&self, _program: &Pubkey) -> LoadedProgramMatchCriteria { | ||
| LoadedProgramMatchCriteria::NoCriteria | ||
| } |
There was a problem hiding this comment.
Shouldn't we leave the default implementation empty?
There was a problem hiding this comment.
This behavior is very Solana specific. If other users can handle cold starts better, they shouldn't need to implement this function. So there's a default implementation.
LucasSte
approved these changes
Mar 20, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
* Move code to check_program_modification_slot out of SVM * add documentation for the public function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The code to
check_program_modification_slotdoesn't belong in SVM. It's an implementation detail that should be handled by the user of SVM.Summary of Changes
Move the code out of SVM and call it using a trait method.
Fixes #