Health check slot distance #335
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 837 837
Lines 226898 226898
=======================================
+ Hits 185871 185892 +21
+ Misses 41027 41006 -21 |
There was a problem hiding this comment.
This looks good to me, thanks for raising / making the PR!
It looks like 128 originates from here:
solana-labs@8e2745c2a24
and 150 from here:
solana-labs@40737e9efa4
@CriesofCarrots - Do you have any reservations about this change? Technically, I think 150 pre-dates 128, but 128 is in a more visible place and a power-of-2 😉 .
Technically, this will make the healthy/not-healthy bound a little stricter for validators, but 128 is still pretty gratuitous. I'm inclined to think that the use of different values was just a minor oversight
|
As a validator (speaking just for myself), I would prefer the stricter health check that is in line with the definition of delinquency. It makes sense that you would want to make sure your validator was not delinquent to be considered "healthy". 150 gets you close, but I can't think of any reason for the extra grace in this circumstance. |
There was a problem hiding this comment.
@CriesofCarrots - Do you have any reservations about this change? Technically, I think 150 pre-dates 128, but 128 is in a more visible place and a power-of-2 😉 .
Given that the value is still configurable, I don't have any reservations. Might be worth mentioning in the changelog, though.
|
Ohh yeah, good call on changelog. @bartenbach, can you please make an addition there as well: Something like:
I don't anticipate us BP'ing this change, so I think under the |
Problem
Default health check size is arbitrary and inconsistent with delinquency constant.
Summary of Changes
Changes arbitrary health check slot distance to delinquency constant.