remove solana-sdk from solana-timings

[kevinheavey]

Problem

This crate can compile faster without solana-sdk

Summary of Changes

• Use solana-pubkey instead of solana_sdk::pubkey
• Use the saturating_add_assign crate instead of solana_sdk::saturating_add_assign. I copied this macro from solana-sdk and published it in a standalone crate. I did this because it seems silly to include this in the normal Agave publishing workflow when this crate will probably never change. For that reason I also pinned the version to "=1.0.0".

That said, I would make no objection to just copy-pasting the macro into solana-timings and other crates

[steviez]

agave/sdk/src/lib.rs

Lines 206 to 213 in 86a7062

	/// Convenience macro for `AddAssign` with saturating arithmetic.
	/// Replace by `std::num::Saturating` once stable
	#[macro_export]
	macro_rules! saturating_add_assign {
	($i:expr, $v:expr) => {{
	$i = $i.saturating_add($v)
	}};
	}

Saturating is stable as of 1.74.0:
https://doc.rust-lang.org/std/num/struct.Saturating.html

So, I think I'd prefer to see us update to use Saturating<T> in solana-timings instead of shifting the macro + depending on the new crate

Certainly out of scope for this PR, but replacing all instances of saturating_add_assign! with Saturating<T> would be nice too

[mergify]

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

[kevinheavey]

@steviez done. I regret doing this because it looked like a small change at first

[steviez]

@steviez done. I regret doing this because it looked like a small change at first

After I commented, I started making the change as well and then also realized it went a lot further than just solana-timing so thank you for doing it

[steviez]

Apologies on the delayed review, but this LGTM! Tedious work but the right move long term.

Looks like we need a review from @anza-xyz/svm too; I'll try to poke someone from there too