v2.0: cli: show max vote credits in vote-account based on TVC activation epoch (backport of #3776) #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
AshwinSekar
force-pushed
the
mergify/bp/v2.0/pr-3776
branch
3 times, most recently
from
0e0992c to
f37d2b8
Compare
AshwinSekar
force-pushed
the
mergify/bp/v2.0/pr-3776
branch
from
f37d2b8 to
0acdd15
Compare
|
Looking to backport this CLI change so that operators have an accurate view of their vote account now that TVC has been activated |
jstarry
approved these changes
Nov 27, 2024
t-nelson
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Show vote account CLI compares the credits earned vs slots in epoch.
This is a faulty comparison as with TVC validators can earn up to 16 credits per slot.
Summary of Changes
Add a multiplier based on whether TVC was active in that epoch for a fair comparison
This is an automatic backport of pull request #3776 done by [Mergify](https://mergify.com).