Don't populate uncleaned_roots at index generation in startup. #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaoranYi
changed the title
HaoranYi
force-pushed
the
no_dup_slot_index_gen
branch
from
89fde0a to
273d9da
Compare
inline reduce
HaoranYi
force-pushed
the
no_dup_slot_index_gen
branch
from
273d9da to
ad086d5
Compare
brooksprumo
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
uncleaned_rootsis no longer required for clean (thanks to #4092). However, we are still populating them at startup.Summary of Changes
Don't populate uncleaned_roots for clean at startup.
Fixes #