remove solana-sdk from address-lookup-table-program #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
kevinheavey
force-pushed
the
alt-program-rm-sdk
branch
from
7a9f810 to
01fc970
Compare
LucasSte
reviewed
Jan 6, 2025
| @@ -25,7 +23,7 @@ declare_process_instruction!(Entrypoint, DEFAULT_COMPUTE_UNITS, |invoke_context| | |||
| let transaction_context = &invoke_context.transaction_context; | |||
| let instruction_context = transaction_context.get_current_instruction_context()?; | |||
| let instruction_data = instruction_context.get_instruction_data(); | |||
| match limited_deserialize(instruction_data)? { | |||
| match limited_deserialize(instruction_data, solana_packet::PACKET_DATA_SIZE as u64)? { | |||
There was a problem hiding this comment.
this was calling the wrapper function in solana-sdk:
agave/sdk/src/program_utils.rs
Line 9 in d303032
I replaced it with the inner function which has the same name and takes a size parameter
LucasSte
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This crate no longer needs all of solana-sdk
Summary of Changes
Remove and replace with component crates