v2.0: deplete compute meter for vm errors (backport of #3751 and #3994) #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: deplete compute meter for vm errors * add tests * rekey apply_cost_tracker_during_replay (cherry picked from commit b120fc1) # Conflicts: # programs/sbf/tests/programs.rs # sdk/src/feature_set.rs
|
The Firedancer team maintains a line-for-line reimplementation of the |
This was referenced Jan 6, 2025
|
sorry, missed this before. no 
|
Lichtso
approved these changes
Jan 14, 2025
|
Closing this one... Re-open individual BPs if needed. V2.0 should be EOL in about 3 weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implements solana-foundation/solana-improvement-documents#182 by making sure that programs that fail with VM errors consume the remaining compute budget to simplify compute unit handling. Uses new feature gate.
Summary of Changes
Feature Gate Issue: #3993