Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove solana-sdk from vote-program #4331

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

kevinheavey
Copy link

Problem

This crate no longer needs all of solana-sdk

Summary of Changes

Replace with component crates

Copy link

mergify bot commented Jan 7, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Copy link

@AshwinSekar AshwinSekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this.
@lidatong can you confirm that FD is good with this refactor? Should require no changes, just a refactor of imports.

@lidatong
Copy link

lidatong commented Jan 9, 2025

Looks good, thanks for doing this. @lidatong can you confirm that FD is good with this refactor? Should require no changes, just a refactor of imports.

good on our side thanks

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 9, 2025
@mergify mergify bot merged commit b4dc7e0 into anza-xyz:master Jan 9, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants