wrapper around jemalloc to track allocator usage by thread #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpyattaev
force-pushed
the
memory_metrics
branch
2 times, most recently
from
414d8b5 to
0ec36fd
Compare
alexpyattaev
force-pushed
the
memory_metrics
branch
from
0ec36fd to
5a8f13a
Compare
alexpyattaev
force-pushed
the
memory_metrics
branch
2 times, most recently
from
34d7de8 to
b2ac2f7
Compare
alexpyattaev
force-pushed
the
memory_metrics
branch
from
b2ac2f7 to
6df862a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple wrapper around jemalloc to track allocator usage by thread name in metrics.
Idea is to get a better idea why node crashes when OOM occurs (at least which threads were allocating memory).
This is for dev use only.
Problem
If/when agave starts leaking memory (or just clogging up some channel) it may be tricky to find where memory allocations are happening that cause the crash. Tracking per-pool allocations is not a replacement for valgrind, but has the advantage of fairly small overhead & integration into metrics.
Summary of Changes
Added feature-flag gated custom wrapper around jemalloc that tracks memory usage, grouped by thread pool name.