-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces static mutable references in entry #4418
Replaces static mutable references in entry #4418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@bw-solana Can I get your review here as well, please? I want to make sure I haven't missed anything. Feel free to tag in others to review as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one minor suggestion
@@ -51,23 +51,22 @@ fn init(name: &OsStr) { | |||
static INIT_HOOK: Once = Once::new(); | |||
|
|||
info!("Loading {:?}", name); | |||
unsafe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
4952a37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
New clippy lints when upgrading to rust 1.84.0.
Some are related to creating references to mutable statics. Here's the new lint for
entry
:Summary of Changes
Replace
Once
withOnceLock
for the API, as it is the preferred way to doOnce
+data.Partially fixes #4380