v2.1: fix: use atomic to check if leader bank changed (backport of #4596) #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: use atomic to check if leader bank changed * fix default value and tests * ordering update * eedback * add comment (cherry picked from commit 4cc49ac)
|
adding SME reviewers |
apfitzge
approved these changes
Jan 24, 2025
t-nelson
approved these changes
Jan 24, 2025
bw-solana
reviewed
Jan 24, 2025
There was a problem hiding this comment.
overall, this seems fine to me.
but just to play the other side, what is the urgency to backport this? Looks like the fix only landed in master a couple days ago, have we had much test/bake time?
my understanding is we only interrupt the leader bank when some new block is replayed and new majority fork discovered (e.g. slow leader before us builds a new block), but this is somewhat rare, so I don't anticipate huge block capacity unlocks from this improvement
|
@bw-solana no crazy urgency but definitely should be fixed and backported. We should make sure this bakes a bit on a staked validator before encouraging mainnet operators to adopt it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Banking stage consume workers don't check if a leader bank got interrupted while consuming work. This can cause them to get stuck consuming work for a bank that was abandoned rather than switching to the newest leader bank.
Summary of Changes
Add a lightweight atomic variable which holds the current leader bank id and check it before each consumed piece of work to see if the bank was interrupted.
Fixes #
This is an automatic backport of pull request #4596 done by [Mergify](https://mergify.com).