Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic instructions for deploying POS app on Vercel #123

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Basic instructions for deploying POS app on Vercel #123

merged 6 commits into from
Apr 29, 2022

Conversation

cogoo
Copy link
Collaborator

@cogoo cogoo commented Apr 23, 2022

Basic instructions for deploying POS app on Vercel

Commits:

  • docs(images): pOS deployment reference images
  • docs(point of sale): vercel deployment instructions for point of sale app

@vercel
Copy link

vercel bot commented Apr 23, 2022

@cogoo is attempting to deploy a commit to the Solana Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solana-pay-docs ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 7:22PM (UTC)

@cogoo
Copy link
Collaborator Author

cogoo commented Apr 23, 2022

Reminder:

Once core SDK is deployed, we have to update the version of @solana/pay in point-of-sale/package.json

jordaaash
jordaaash reviewed Apr 28, 2022
View reviewed changes
point-of-sale/README.md
Comment on lines +160 to +161
RATE_LIMIT=10
RATE_LIMIT_INTERVAL=60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip these two env vars here I think. If we add a default endpoint in the code, we can skip all 3 and the entire env var config input step in the screenshots.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one env var that we need that's missed here. The SECRET_KEY

@cogoo
Copy link
Collaborator Author

cogoo commented Apr 28, 2022

It's worth having the environment variables section there, since the values are actually configurable, but toned down the importance since they're optional

@jordaaash jordaaash merged commit 5fc1926 into anza-xyz:link-request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaaash jordaaash jordaaash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cogoo @jordaaash