More comments and fmt cleanup

executable.go

@@ -1,11 +1,5 @@
 package sol
 
-import ()
-
-type destination struct {
-	value interface{}
-}
-
 type Executable interface {
 	Compiles
 }

insert.go

@@ -11,6 +11,7 @@ import (
 )
 
 var (
+	// ErrNoColumns is returned when a query for one columns returns none
 	ErrNoColumns = errors.New(
 		"sol: attempt to create a statement with zero columns",
 	)
@@ -72,7 +73,7 @@ func (stmt InsertStmt) Compile(d dialect.Dialect, ps *Parameters) (string, error
 	if rows == 0 {
 		rows = 1
 		stmt.args = make([]interface{}, cols)
-		for i, _ := range stmt.args {
+		for i := range stmt.args {
 			stmt.args[i] = nil
 		}
 	}
@@ -357,7 +358,7 @@ func removeColumn(columns []Columnar, name string) []Columnar {
 func valuesMap(stmt InsertStmt, values Values) (fields, error) {
 	fields := make(fields, len(values))
 	var i int
-	for column, _ := range values {
+	for column := range values {
 		if !stmt.Has(column) {
 			return nil, fmt.Errorf(
 				"sol: cannot INSERT a value with column '%s' as it has no corresponding column in the INSERT statement",
@@ -372,7 +373,7 @@ func valuesMap(stmt InsertStmt, values Values) (fields, error) {
 // Insert creates an INSERT statement for the given columns. There must be at
 // least one column and all columns must belong to the same table.
 func Insert(selections ...Selectable) (stmt InsertStmt) {
-	columns := make([]Columnar, 0)
+	var columns []Columnar
 	for _, selection := range selections {
 		if selection == nil {
 			stmt.AddMeta("sol: INSERT received a nil selectable - do the columns or tables you selected exist?")

modifier.go

@@ -1,7 +1,5 @@
 package sol
 
-import ()
-
 type Modifier interface {
 	Modify(*TableElem) error
 }

parameters.go

@@ -4,6 +4,8 @@ import (
 	"github.com/aodin/sol/dialect"
 )
 
+// Parameter is a value that will be passed to the database using a
+// dialect specific parameterization
 type Parameter struct {
 	Value interface{}
 }
@@ -15,16 +17,20 @@ func (p *Parameter) Compile(d dialect.Dialect, ps *Parameters) (string, error) {
 	return d.Param(ps.Len() - 1), nil
 }
 
+// Parameters aggregated values before parameterization
 type Parameters []interface{}
 
+// Add adds a parameter
 func (ps *Parameters) Add(param interface{}) {
 	*ps = append(*ps, param)
 }
 
+// Len returns the length of the Parameters
 func (ps *Parameters) Len() int {
 	return len(*ps)
 }
 
+// Params creates a new Parameters
 func Params() *Parameters {
 	return &Parameters{}
 }

postgres/serial.go

@@ -5,7 +5,7 @@ import (
 	"github.com/aodin/sol/types"
 )
 
-// serial is a postgres-specfic auto-increment type. It implies NOT NULL.
+// serial is a postgres-specific auto-increment type. It implies NOT NULL.
 type serial struct {
 	name     string
 	isUnique bool
@@ -22,11 +22,13 @@ func (t serial) Create(d dialect.Dialect) (string, error) {
 	return compiled, nil
 }
 
+// Unique sets the serial type as unique
 func (t serial) Unique() serial {
 	t.isUnique = true
 	return t
 }
 
+// Serial creates a new serial type
 func Serial() (t serial) {
 	t.name = "serial"
 	return

result.go

@@ -15,6 +15,7 @@ type Scanner interface {
 	Scan(...interface{}) error
 }
 
+// Result is returned by a database query - it implements Scanner
 type Result struct {
 	stmt string
 	Scanner
@@ -46,7 +47,7 @@ func (r *Result) One(arg interface{}) error {
 		// TODO scan directly into values?
 		addr := make([]interface{}, len(columns))
 		dest := make([]interface{}, len(columns))
-		for i, _ := range addr {
+		for i := range addr {
 			dest[i] = &addr[i]
 		}
 
@@ -240,7 +241,7 @@ func (r *Result) All(arg interface{}) error {
 			// TODO scan directly into values?
 			addr := make([]interface{}, len(columns))
 			dest := make([]interface{}, len(columns))
-			for i, _ := range addr {
+			for i := range addr {
 				dest[i] = &addr[i]
 			}
 

select.go

@@ -146,7 +146,7 @@ func (stmt SelectStmt) hasTable(name string) bool {
 	return false
 }
 
-// All removes the DISTINCT clause from the SELECT statment.
+// All removes the DISTINCT clause from the SELECT statement.
 func (stmt SelectStmt) All() SelectStmt {
 	stmt.isDistinct = false
 	stmt.distincts = nil