Feature/5659 add metadata link #106
Conversation
| @@ -19,7 +19,7 @@ const ContactBlock: React.FC<ContactBlockProps> = ({ title, contacts }) => { | |||
| key={index} | |||
| title={contact.organization + suffix} | |||
| isContactFragment | |||
| email={contact.emails[0]} | |||
| email={contact.emails ? contact.emails[0] : undefined} | |||
There was a problem hiding this comment.
no big deal, but what if contact.emails[0] = ""?
There was a problem hiding this comment.
If any details is falsy("", undefined, null, etc...), the corresponding area will show something like "no *** data". Steve has this design, but it needed to change according to their discussion. So I will implement all the falsy data when the design is approved. I will then raise a ticket for it (will paste the link here shortly)
There was a problem hiding this comment.
| @@ -70,7 +89,7 @@ const MetadataInformationPanel = () => { | |||
| }, | |||
| { | |||
| title: "Full Metadata Link", | |||
| component: <div>full metadata link</div>, | |||
| component: <PlainLinkBlock url={metadataLink} />, | |||
There was a problem hiding this comment.
so why dont you call PlainLinkBlock to be MetadataLinkBlock? unless plain link block is something called by STAC, I'd suggest a different name for clarity. "Plain" can be replaced by something else / or not needed at all.
| import BlockList from "./BlockList"; | ||
| import { Link } from "@mui/material"; | ||
|
|
||
| interface PlainLinkBlockProps { |
src/components/list/LinkList.tsx
Outdated
| url: string; | ||
| } | ||
|
|
||
| const PlainLinkBlock: React.FC<PlainLinkBlockProps> = ({ url }) => { | ||
| const LinkList: React.FC<LinkListProps> = ({ url }) => { |
There was a problem hiding this comment.
this name can be confusing with https://en.wikipedia.org/wiki/Linked_list
There was a problem hiding this comment.
oh, sorry. Let me change another one
src/components/list/LinkList.tsx
Outdated
| @@ -20,4 +20,4 @@ const PlainLinkBlock: React.FC<PlainLinkBlockProps> = ({ url }) => { | |||
| return <ExpandableList title={"Full Metadata Link"} childrenList={link} />; | |||
There was a problem hiding this comment.
you are hard-coded "metadata link" here, so this component is for list of "metadata link" only?
This reverts commit f0bc1d6.
No description provided.