-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/5751 add spider diagram to map #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
Few more comments but can fixed in next iteration, please raise tickets to capture these and other comments after the end of iteration review
I am ok to approve the PR once the comment inside the code addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once more minor comment
Thanks Raymond! I agree to spiderify earlier, but it may take some time to adjust the function of calculating the radius of the spider diagram and legs/pins size to scale up/down the diagram when changing the spiderifyFromZoomLevel. For the second point I will fix it by making the unspiderify more sensitive to the zoom out (for now it will disappear with zoom out but not so quickly) So I will raise another ticket to fix it together with other function/style issues of spider diagram in next iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please raise ticket for remain change and put links here thanks |
A ticket to adjust the variable spiderifyFromZoomLevel to make the spiderify appear more earlier https://github.com/aodn/backlog/issues/5810 |
No description provided.