Refactor/5813 change links implementation #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NekoLyn
approved these changes
Aug 20, 2024
| @@ -31,7 +32,7 @@ const MetadataContactList: React.FC<MetadataContactListProps> = ({ | |||
| <MailOutlineIcon /> | |||
| </Grid> | |||
| <Grid item md={11} sx={{ textAlign: "left", whiteSpace: "normal" }}> | |||
| <Link href={`mailto:${contact.emails[0]}`}> | |||
| <Link href={`mailto:${email ? email : ""}`}> | |||
There was a problem hiding this comment.
do you think can use email ?? "" here? because here email is a string and you check it is undefined or not
but just be careful: ? is used for truthiness check and ?? is used for null check.
so when check a number or boolean it will be tricky and should carefully decide which is correct for use.
There was a problem hiding this comment.
I just don't want any falsy data in most of the case so i use ternary operator a lot. But because almost all the data are strings actually, so both ways are all doing the same thing for these cases. Thank you for your reminding😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
For the links showing in the search page
and the ones in detail page link panel, they are all links under "distribution" in geonetwork.
So now using relation
relatedto tell these links from all links.Also change relation for metadata link (
self->describedby), and thumbnail links (thumbnail->preview);Optimize some code for better display. Now, the display won't be weird in some bad case (e.g., if a part of a data is empty, such as a contact doesn't have link).