Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5882 update and fix #154

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Feature/5882 update and fix #154

merged 6 commits into from
Sep 12, 2024

Conversation

NekoLyn
Copy link
Contributor

@NekoLyn NekoLyn commented Sep 11, 2024

  1. update footer according to chat with Vicky:
    default email subject: "AODN Data Discovery enquiry"
    default email body:"This is a test - please ignore"

  2. fix minor UI issue

Copy link
Contributor

@HavierD HavierD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others are all good, i just found a potential issue. Please use
window.open(url, "_blank", "noopener,noreferrer");
for all windows.open to make the operation more secure.

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HavierD HavierD merged commit 452e7ef into main Sep 12, 2024
3 checks passed
@HavierD HavierD deleted the feature/5882-update-and-fix branch September 12, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants