Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter fixed in search page #5492 #18

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

HavierD
Copy link
Contributor

@HavierD HavierD commented Apr 16, 2024

No description provided.

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Can you make the spacing correct for the depth box and expand it to cover the cell?

Also change the z-index fo that mapbox logo and disclaimer of mapbox do not show on top of the filter?

@utas-raymondng
Copy link
Contributor

@HavierD
Copy link
Contributor Author

HavierD commented Apr 17, 2024

hi @utas-raymondng, I would like clarifying something.

for this one:

Can you make the spacing correct for the depth box and expand it to cover the cell?

did you mean the numbers on the left mismatch the numbers on the vertical selector on the right? As the image below:
image

And for this one:

And the filter popup seems a bit off please refer to https://www.figma.com/file/hfaM4qNeEdTaayeTde8HYH/AODN-UX-Process_06-Specification_RC1?type=design&node-id=0-1&mode=design&t=58eYGH6ml86fFUiT-0

I didn't get the point. I am not sure what you wanna me to change because currently a lot of features are different from the design. I just added depth selector and didn't touch other part.

------------------------------UPDATE--------------------------------
Thanks Raymond. My monitors' contrast is 100% so I cannot see the background color :(. I will fix it soon.

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit 8be8932 into main Apr 17, 2024
2 checks passed
@HavierD HavierD deleted the upgrade/make-filter-align-design#5492 branch April 17, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants