Fix abstract format issue on UI #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HavierD
requested changes
Oct 31, 2024
| return ( | ||
| <TextAreaBaseGrid> | ||
| <Grid item md={12}> | ||
| <Typography | ||
| variant="detailContent" | ||
| component="div" | ||
| dangerouslySetInnerHTML={{ |
There was a problem hiding this comment.
Could you try not to use dangerouslySetInnerHTML? Because it exposes our portal to XSS attacks.
There was a problem hiding this comment.
I disable the dangerouslySetInnerHTML for now, but we lost the ability to click on the link within the abstract
| component="div" | ||
| dangerouslySetInnerHTML={{ | ||
| __html: isExpanded | ||
| ? isEnrichHtml |
There was a problem hiding this comment.
Can this nested ternary conditional operator be more readable? e.g.:
const generateText = () => {
return isExpanded? decodedText : truncateText(decodedText, truncateCount);
}
... other code...
isEnrighHtml? enrichHtml (geenrateText()) : generateText();There was a problem hiding this comment.
Remove the isEnrichHTML option so it is not there now
| @@ -63,3 +75,6 @@ const ExpandableTextArea: React.FC<ExpandableTextAreaProps> = ({ | |||
| }; | |||
|
|
|||
| export default ExpandableTextArea; | |||
| function enrchHTML(arg0: string) { | |||
There was a problem hiding this comment.
I believe this function is auto-generated by IDE when you click "create function" accidently. Could you remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this to do testing uuid for testing
1045cb37-d0de-4596-8e5f-c9e77df44742,
you may need to reload this one with indexer