Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ implement full list view and fetch more #224

Merged
merged 5 commits into from
Nov 21, 2024
Merged

✨ implement full list view and fetch more #224

merged 5 commits into from
Nov 21, 2024

Conversation

NekoLyn
Copy link
Contributor

@NekoLyn NekoLyn commented Nov 20, 2024 •
edited
Loading

a simple full list view, need to improve styles and implement button functions, can raise a follow up ticket according to feedback

TODO:

  1. need pin list? if need, should put in higher level so pin list can be remembered after switching view mode or pages
  2. bug: default fetch page size is 11 when changing sort options in full list view

image

image

utas-raymondng
utas-raymondng requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have a quick chat on some of these changes

src/pages/search-page/SearchPage.tsx Show resolved Hide resolved
src/components/result/FullListAndDetails.tsx Outdated Show resolved Hide resolved
utas-raymondng
utas-raymondng approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit 962e3ae into main Nov 21, 2024
3 checks passed
@NekoLyn NekoLyn deleted the feature/6038-full-list-and-detail-view branch November 21, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utas-raymondng utas-raymondng utas-raymondng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NekoLyn @utas-raymondng