Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/6172 responsive layout landing page #260

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

NekoLyn
Copy link
Contributor

@NekoLyn NekoLyn commented Jan 12, 2025

No description provided.

@utas-raymondng
Copy link
Contributor

Found two issues

  1. Once you click the dropdown on top, it will be there forever
  2. The button of the search bar drop out, not sure what is the right design
    image

@utas-raymondng
Copy link
Contributor

Found two issues

1. Once you click the dropdown on top, it will be there forever

2. The button of the search bar drop out, not sure what is the right design
   ![image](https://private-user-images.githubusercontent.com/101624355/402396946-f0acfae5-e23f-4f6e-a168-f7c04d59c491.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY3Mjc2NDcsIm5iZiI6MTczNjcyNzM0NywicGF0aCI6Ii8xMDE2MjQzNTUvNDAyMzk2OTQ2LWYwYWNmYWU1LWUyM2YtNGY2ZS1hMTY4LWY3YzA0ZDU5YzQ5MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDExM1QwMDE1NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mM2FlOTRmNmU4MGRiNWNjYWY1Nzg5M2ZjYmUwZjVmMzIwYzI0MWRiOGRiN2QwMGU2OWJjMTMxOTIyNmE0MjczJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.TguuTIjChBwWsm4fq0QEaG5DZtFaBRR7RSrMw-ltyQ8)

Ignore above

  1. This due to the need to select the touch button on the web browser to simulate the finger operation
  2. Need @quye04 update design on where the button goes

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit 6a25668 into main Jan 13, 2025
3 checks passed
@NekoLyn NekoLyn deleted the feature/6172-responsive-layout-landing-page branch January 13, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants