-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/5713 add hover tip for spatial extents #74
Feature/5713 add hover tip for spatial extents #74
Conversation
NekoLyn
commented
Jul 5, 2024
•
edited
Loading
edited
- fix showing overlapping spatial extents when click on a single unclustered point
- create a simple popup for hovering on a single unclustered point (different from design which is too big and contains too much information, and may need change later according to Steve @quye04 )
- adjust search page height to be adaptive to the screen height
- adjust the cluster size to make less unclustered points on map
I'm reviewing it's a long one @utas-raymondng , FYI so you won't do duplicate work. @NekoLyn if you requested me and I'm in it, make sure to communicate before you request another person. |
.github/ISSUE_TEMPLATE/as-a--type-of-user--i-want--some-goal--so-that--some-reason-.md
Show resolved
Hide resolved
@NekoLyn remove me from reviewer, I let @vietnguyengit do it this time |
somehow cannot remove you from reviewer since you have made comments...I think one approvement is enough maybe..If it needs your approvement I will ping you |
I saw you've ticked "Resolved" for the comments but I cannot find new commits or new changes to some comments requiring code changes @NekoLyn |
Hi I just request the review. Had some problem with pc just restarted it and commit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this to @vietnguyengit
just wonder why your commits always have |
was that git asking you to rebase or you choose to do so? @NekoLyn |
I choose to do it. but githut will also detect if the commit is ahead or behind 'main'. if the commits are ahead of 'main', then someone can merge the pr. however if the commits are behind 'main' then you need to rebase before merge, which may casue unsolved conflicts. That's why i will check any updates of 'main' and merge then resolve potential confilcts before pushing commit. |
This line is I merge lastest pr that mereged to 'main'. The commit message is different from Raymond and Havier due to using different IDE (I am using VS code and they may use the Intellij) |