Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor remove onClickPopup and add static layers #98

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

utas-raymondng
Copy link
Contributor

@NekoLyn can you help me to check if you still need the onClickPopup? Looks like not required

@NekoLyn
Copy link
Contributor

NekoLyn commented Jul 22, 2024

@utas-raymondng we don't need click popup for now, please delete it, thanks!

@utas-raymondng utas-raymondng changed the title refactor remove onClickPopup refactor remove onClickPopup and add static layers Jul 23, 2024
@NekoLyn
Copy link
Contributor

NekoLyn commented Jul 24, 2024

it looks good to me!
just a small concern that we may need a rule to decide which layer should stay on top which one at bottom?
image

@utas-raymondng
Copy link
Contributor Author

The layer always at bottom I think

@NekoLyn NekoLyn merged commit ec1c235 into main Jul 24, 2024
2 checks passed
@NekoLyn NekoLyn deleted the features/5770-static-layers branch July 24, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants