Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome.angle] Force Pure RISCV64 Support #4

Closed
wants to merge 2 commits into from
Closed

[chrome.angle] Force Pure RISCV64 Support #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a752e90
[Android] Force Pure RISCV64 Support
McKnight22 Mar 19, 2023
92f6869
[chrome.angle] Force Pure RISCV64 Support - PatchSet.1
McKnight22 Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/angle_apk.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ if (enable_java_templates) {
deps = [ ":${invoker.package_name}_assets" ]
if (symbol_level != 0) {
deps += [ ":compressed_symbols" ]
if (android_64bit_target_cpu) {
if (android_64bit_target_cpu && defined(android_secondary_abi_cpu)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd review:
建议用 android_secondary_abi_toolchain, 和下面代码结合比较紧密，好理解。

deps += [ ":compressed_symbols($android_secondary_abi_toolchain)" ]
}
}

uncompress_shared_libraries = true

if (android_64bit_target_cpu) {
if (android_64bit_target_cpu && defined(android_secondary_abi_cpu)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd review:
建议用 android_secondary_abi_toolchain, 和下面代码结合比较紧密，好理解。

if (symbol_level == 0) {
secondary_abi_shared_libraries = []
foreach(_library, angle_libraries) {
Expand Down