[chrome.ndk] revert change to keep align with ndk 22/23 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using latest ndk header files from google upstream, which is different against the ndk matching chrome 109. For ./toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/android/looper.h, new version marked ALooper_pollAll with "__REMOVED_IN(1)", while in ndk for chrome 109, there is no such flag. Diff and see only this change happened for looper.h. Current solution: revert and removed the "__REMOVED_IN(1)". FIXME: The final solution may be a new ndk, with: - proper files match ndk 22/23 that chrome 109 depends on - proper kernel uapi header files of 5.10 that aosp12/riscv64 for T-HEAD dev board. Signed-off-by: Wang Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using latest ndk header files from google upstream, which is different against the ndk matching chrome 109.
For ./toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/android/looper.h, new version marked ALooper_pollAll with "__REMOVED_IN(1)", while in ndk for chrome 109, there is no such flag.
Diff and see only this change happened for looper.h.
Current solution: revert and removed the "__REMOVED_IN(1)".
FIXME: The final solution may be a new ndk, with: