[chrome.v8] fixed the error libs not defined #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when gn with target_os = "android" and target_cpu = "riscv64"
libs may be not defined when goto
```
if (v8_current_cpu == "riscv64" || v8_current_cpu == "riscv32") {
libs += [ "atomic" ]
}
```
unicornx
changed the title
unicornx
changed the title
unicornx
pushed a commit
that referenced
this pull request
May 22, 2023
... on non-ChromeOS devices. Bug: v8:11880, chromium:1400973 Change-Id: Id9914572d44c07d0ae1a1bd5d1cb25e8270c864b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4287218 Auto-Submit: Igor Sheludko <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/main@{#86129}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when gn with target_os = "android" and target_cpu = "riscv64"
libs may be not defined when goto