Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New features, bugfixes, better testing #187

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

New features, bugfixes, better testing #187

wants to merge 22 commits into from

Conversation

adamhotep
Copy link

@adamhotep adamhotep commented May 29, 2023 •
edited
Loading

  • Resolves Benchmark script is broken #128 (bench with neovim) via #127
  • Fixes other bugs in the bench script (e.g. vim packages support, -o doesn't work)
  • Resolves Support for unitless hsl values in Sass #140 (non-percent saturation/luminance for SASS & SCSS)
  • Resolves Error when writing an invalid RGB color #151 (color overflows)
  • Refuses to render invalid color specifications (e.g. color: rgb(0, 17, 136 / 100%))
  • Adds much more comprehensive test suites for css and html, including items that should not be colored.
  • Implements HSL (Hue, Saturation, Lightness) angles (e.g. color: hsl(167grad, 30%, 60%))
  • Implements HWB (Hue, Whiteness, Blackness) function coloring
  • Supports decimals and spaced values (e.g. color: rgb(0 16.99 136))
  • Support legacy HTML3-style colors (e.g. <body text="blue"> and <font color="#abcdef">)
  • Probably some more

Benchmark testing showed no appreciable increase in cost to run, but I don't like how inconsistent its stats are.

To implement hwb(), I abstracted hsl2color() to hsl2rgb() in order to retain the RGB channels. While at it, I also converted the other similar functions so there's now only one place where RGB is converted to hexadecimal representation.

adamhotep added 16 commits May 26, 2023 17:59
@adamhotep
overflow check
3e7d1de 
fixes ap#151
@adamhotep
support for decimals and spaced color values
7d597ee
@adamhotep
awk is faster and more broadly installed than perl, support neovim an…
583e8c2 
…d vim packages
@adamhotep
more comprehensive tests
a696232
@adamhotep
support overflow/wraparound values, stricter adherence to formats, ad…
b54bcf5 
…ded support for different angle units, hwb(), and decimal values
@adamhotep
bench script didn't work with -o, split it up per-file and added a "t…
993a0a5 
…otal"

(which you'll notice is quite a bit higher than -o would have shown)
@adamhotep
better comment for pctvet
928bee7
@adamhotep
removed hack to avoid white-space since it's already avoided by isk…
caaf911 
…eyword including dashes

(Also: it doesn�t work; try a similar exclusion to avoid `width: calc(100px * tan(45deg))` and you'll find you can�t.)
@adamhotep
bench: run bc just once, exit cleanly unless the syntax was never run
9ba1cc7
@adamhotep
consistent test order for FP section
8bfd21e
@adamhotep
HTML: fix broken CSS syntax within HTML attributes, add legacy HTML3 …
342554c 
…color attribute support
@adamhotep
HTML: tests for legacy HTML3 colors, etc
42f7c03
@adamhotep
commented "solution" to coloring the tan() function
5dda713
@adamhotep
address the concern in ap#127 by canonicalizing the path
1db0b4d 
also made the default run (all test files) work from any directory
@adamhotep
fix ap#140
a6846bf 
Support non-percent saturation/luminance & whiteness/blackness in SASS and SCSS but prevent them in standard CSS
@adamhotep
html3 colors don't support color functions. Just names and 3/6-digit hex
e31df59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@adamhotep