Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

PySpark Submission Failing on --py-files #407

Merged

Conversation

ifilonenko
Copy link
Member

What changes were proposed in this pull request?

Fixes issue addressed here: #406

How was this patch tested?

Unit + Integration tests + Manual compiling of distribution to run spark-submit

@ifilonenko ifilonenko changed the title Fix bug with null arguments PySpark Submission Failing on --py-files Aug 1, 2017
@erikerlandson erikerlandson mentioned this pull request Aug 1, 2017
10 tasks
@ifilonenko
Copy link
Member Author

Would like someone to also try running spark-submit on distribution environment before merging and get success. It might be wise to think about introducing e2e tests that include spark-submit arguments

@foxish
Copy link
Member

foxish commented Aug 1, 2017

Is this needed on branch-2.1?

@ifilonenko
Copy link
Member Author

Yes we will need to include this in branch-2.1 because #365 was included in that as well

@erikerlandson
Copy link
Member

@ifilonenko with the --jars update working is this good to merge?

@ifilonenko
Copy link
Member Author

Yes. Was wondering if anyone else could test both of these after building the respective docker-images with the PRs changes

  env -i bin/spark-submit \
  --deploy-mode cluster \
  --master k8s://https://192.168.99.100:8443 \
  --kubernetes-namespace default \
  --conf spark.executor.instances=1 \
  --conf spark.app.name=spark-pi \
  --conf spark.kubernetes.driver.docker.image=driver-py:latest \
  --conf spark.kubernetes.executor.docker.image=executor-py:latest \
  --conf spark.kubernetes.initcontainer.docker.image=spark-init:latest \
  --jars local:///opt/spark/examples/jars/spark-examples_2.11-2.2.0-k8s-0.3.0-SNAPSHOT.jar \
  --py-files local:///opt/spark/examples/src/main/python/sort.py \
  local:///opt/spark/examples/src/main/python/pi.py 10
  env -i bin/spark-submit \
  --deploy-mode cluster \
  --master k8s://https://192.168.99.100:8443 \
  --kubernetes-namespace default \
  --conf spark.executor.instances=1 \
  --conf spark.app.name=spark-pi \
  --conf spark.kubernetes.driver.docker.image=driver-py:latest \
  --conf spark.kubernetes.executor.docker.image=executor-py:latest \
  --conf spark.kubernetes.initcontainer.docker.image=spark-init:latest \
  --jars local:///opt/spark/examples/jars/spark-examples_2.11-2.2.0-k8s-0.3.0-SNAPSHOT.jar \
  local:///opt/spark/examples/src/main/python/pi.py 10

@foxish
Copy link
Member

foxish commented Aug 3, 2017

Trying this change now.

@foxish
Copy link
Member

foxish commented Aug 3, 2017

LGTM, merging. Thanks @ifilonenko

@foxish foxish merged commit 2c5d784 into apache-spark-on-k8s:branch-2.2-kubernetes Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants