feat: add sort by metric for charts with multiple metrics (#952)

Including - legacy-plugin-chart-pivot-table - legacy-plugin-chart-parallel-coordinates - legacy-plugin-chart-treemap
apache-superset · Feb 18, 2021 · b3cdb8d · b3cdb8d
1 parent bc0e3d5
commit b3cdb8d
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/plugins/legacy-plugin-chart-parallel-coordinates/src/controlPanel.ts b/plugins/legacy-plugin-chart-parallel-coordinates/src/controlPanel.ts
@@ -31,6 +31,18 @@ const config: ControlPanelConfig = {
         ['secondary_metric'],
         ['adhoc_filters'],
         ['limit', 'row_limit'],
+        ['timeseries_limit_metric'],
+        [
+          {
+            name: 'order_desc',
+            config: {
+              type: 'CheckboxControl',
+              label: t('Sort Descending'),
+              default: true,
+              description: t('Whether to sort descending or ascending'),
+            },
+          },
+        ],
       ],
     },
     {

diff --git a/plugins/legacy-plugin-chart-pivot-table/src/controlPanel.ts b/plugins/legacy-plugin-chart-pivot-table/src/controlPanel.ts
@@ -38,6 +38,18 @@ const config: ControlPanelConfig = {
         ['groupby'],
         ['columns'],
         ['row_limit', null],
+        ['timeseries_limit_metric'],
+        [
+          {
+            name: 'order_desc',
+            config: {
+              type: 'CheckboxControl',
+              label: t('Sort Descending'),
+              default: true,
+              description: t('Whether to sort descending or ascending'),
+            },
+          },
+        ],
       ],
     },
     {

diff --git a/plugins/legacy-plugin-chart-treemap/src/controlPanel.ts b/plugins/legacy-plugin-chart-treemap/src/controlPanel.ts
@@ -30,7 +30,24 @@ const config: ControlPanelConfig = {
     {
       label: t('Query'),
       expanded: true,
-      controlSetRows: [['metrics'], ['adhoc_filters'], ['groupby'], ['row_limit']],
+      controlSetRows: [
+        ['metrics'],
+        ['adhoc_filters'],
+        ['groupby'],
+        ['row_limit'],
+        ['timeseries_limit_metric'],
+        [
+          {
+            name: 'order_desc',
+            config: {
+              type: 'CheckboxControl',
+              label: t('Sort Descending'),
+              default: true,
+              description: t('Whether to sort descending or ascending'),
+            },
+          },
+        ],
+      ],
     },
     {
       label: t('Chart Options'),