Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add default series_limit #1033

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

etr2460
Copy link
Contributor

@etr2460 etr2460 commented Mar 29, 2021

💔 Breaking Changes
🏆 Enhancements
Makes the change recommended in apache/superset#13802 to help protect performance when grouping by high cardinality dimensions in the default case

Test Plan:
CI

to: @ktmud @michael-s-molina

@etr2460 etr2460 requested a review from a team as a code owner March 29, 2021 21:51
@vercel
Copy link

vercel bot commented Mar 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/HQdNnDXZuT6vFvhPw1iZbnBbZSqF
✅ Preview: https://superset-ui-git-etr2460-default-series-limit-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1033 (6742ced) into master (2af6a24) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1033   +/-   ##
=======================================
  Coverage   27.69%   27.69%           
=======================================
  Files         427      427           
  Lines        8746     8746           
  Branches     1311     1311           
=======================================
  Hits         2422     2422           
  Misses       6151     6151           
  Partials      173      173           
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 38.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af6a24...6742ced. Read the comment docs.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable change.

@ktmud
Copy link
Contributor

ktmud commented Mar 29, 2021

10 may have data accuracy issue if people didn't notice the default is set to 10; 100 sounds about right because it's already very hard to check whether some series is missing among the 100.

@etr2460
Copy link
Contributor Author

etr2460 commented Mar 29, 2021

My thoughts exactly. The row limit is set to 10k (which is crazy large too) so I figured this should err on the larger side too.

@etr2460 etr2460 merged commit 5bd2a14 into master Mar 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the etr2460--default-series-limit branch March 29, 2021 22:17
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
john-bodley added a commit that referenced this pull request Oct 25, 2021
john-bodley added a commit that referenced this pull request Oct 26, 2021
john-bodley added a commit that referenced this pull request Oct 28, 2021
* Revert "feat: add default series_limit (#1033)"

This reverts commit 5bd2a14.

* Update index.tsx

* Update index.tsx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants