-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/HQdNnDXZuT6vFvhPw1iZbnBbZSqF |
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 27.69% 27.69%
=======================================
Files 427 427
Lines 8746 8746
Branches 1311 1311
=======================================
Hits 2422 2422
Misses 6151 6151
Partials 173 173
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a reasonable change.
10 may have data accuracy issue if people didn't notice the default is set to 10; 100 sounds about right because it's already very hard to check whether some series is missing among the 100. |
My thoughts exactly. The row limit is set to 10k (which is crazy large too) so I figured this should err on the larger side too. |
This reverts commit 5bd2a14.
This reverts commit 5bd2a14.
💔 Breaking Changes
🏆 Enhancements
Makes the change recommended in apache/superset#13802 to help protect performance when grouping by high cardinality dimensions in the default case
Test Plan:
CI
to: @ktmud @michael-s-molina