Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(native-filters): add AppSection type #1038

Merged
merged 4 commits into from
Apr 7, 2021
Merged

feat(native-filters): add AppSection type #1038

merged 4 commits into from
Apr 7, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Apr 4, 2021 •
edited by villebro
Loading

🏆 Enhancements
Add AppSection metadata to support functionality in apache/superset#13726 (review)
Changes:

  1. Added AppSection type that specify place of chart on the screen (it's parent component)

@simcha90 simcha90 requested a review from a team as a code owner April 4, 2021 06:42
@vercel
Copy link

vercel bot commented Apr 4, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/8iwv3btnpaaTuq4Novj2jQHkY8Cp
✅ Preview: https://superset-ui-git-fork-simcha90-chart-pace-superset.vercel.app

@simcha90 simcha90 changed the title feat: add Place type feat(native-filters): add Place type Apr 4, 2021
@simcha90 simcha90 mentioned this pull request Apr 4, 2021
Merged
6 tasks
@codecov
Copy link

codecov bot commented Apr 4, 2021 •
edited
Loading

Codecov Report

Merging #1038 (3d9eb50) into master (4e9ec36) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   27.74%   27.76%   +0.01%     
==========================================
  Files         428      428              
  Lines        8758     8760       +2     
  Branches     1314     1314              
==========================================
+ Hits         2430     2432       +2     
  Misses       6155     6155              
  Partials      173      173
Impacted Files Coverage Δ
...es/superset-ui-core/src/chart/models/ChartProps.ts 100.00% <100.00%> (ø)
plugins/plugin-chart-table/src/TableChart.tsx 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9ec36...3d9eb50. Read the comment docs.

villebro
villebro reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please update the title and description to reflect the renamed property

@simcha90 simcha90 changed the title feat(native-filters): add Place type feat(native-filters): add AppSection type Apr 6, 2021
villebro
villebro approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - leaving open for a while for others to chime in.

@villebro villebro merged commit 30232e4 into apache-superset:master Apr 7, 2021
@villebro villebro mentioned this pull request Apr 9, 2021
Merged
8 tasks
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
@simcha90 @NejcZdovc
feat(native-filters): add AppSection type (apache-superset#1038)
5daee01 
* feat: add place type

* refactor: fix CR notes

* docs: update comments

* fix: fix CR notes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simcha90 @villebro