Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(table): groupby filter #1064

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Apr 18, 2021

🏆 Enhancements
Required: apache/superset#14217
Add group by filter for table

Screen.Recording.2021-04-18.at.11.47.59.mov

@simcha90 simcha90 requested a review from a team as a code owner April 18, 2021 09:02
@vercel
Copy link

vercel bot commented Apr 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Dd8s5ei97uNHptbyo9AbWbs4JG4q
✅ Preview: https://superset-ui-git-fork-simcha90-tablegroupby-superset.vercel.app

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d2873ee). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1064   +/-   ##
=========================================
  Coverage          ?   27.80%           
=========================================
  Files             ?      453           
  Lines             ?     9104           
  Branches          ?     1416           
=========================================
  Hits              ?     2531           
  Misses            ?     6382           
  Partials          ?      191           
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/buildQuery.ts 59.25% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2873ee...8efda38. Read the comment docs.

Copy link
Contributor

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@amitmiran137 amitmiran137 merged commit 404c9bb into apache-superset:master Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants