Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(native-filters): support group by feature for server side pagination in table #1072

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

simcha90
Copy link
Contributor

🐛 Bug Fix

  1. Add support for group by filter in server side pagination case in table
  2. Add support only for aggregate mode

@simcha90 simcha90 requested a review from a team as a code owner April 26, 2021 13:19
@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2LSHhVSR3kYyL8ECCcbCRbgX5f43
✅ Preview: https://superset-ui-git-fork-simcha90-tablefixserver-superset.vercel.app

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; however, this looks like a fix - can you update the title and add some context on what the problem is?

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1072 (d65aba3) into master (158a777) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1072   +/-   ##
=======================================
  Coverage   27.80%   27.80%           
=======================================
  Files         453      453           
  Lines        9104     9104           
  Branches     1416     1416           
=======================================
  Hits         2531     2531           
  Misses       6381     6381           
  Partials      192      192           
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/buildQuery.ts 59.25% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158a777...d65aba3. Read the comment docs.

@simcha90 simcha90 changed the title refactor(native-filters): support group by feature for server side pagination in table fix(native-filters): support group by feature for server side pagination in table Apr 26, 2021
@villebro villebro merged commit ed727cb into apache-superset:master Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants