-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/Cid2qsmuSDrtiWYNDXKhHS3HKECR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment wrt typing, other than that looks good (pending the ongoing discussion on wether or not to have drilldown in chart metadata or dataset metadata).
filters: QueryObjectFilterClause[]; | ||
} | ||
|
||
export type OwnState = JsonObject & { drilldown: DrillDownType; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to enforce type checking on OwnState
, we probably need to introduce some named properties while moving the custom ones into nested ones. Something like
{
drilldown: DrillDownType;
customState: JsonObject;
}
In the above example the previous ownState
would be moved into customState
, while drilldown
would be a reserved property for drilldown actions. However, that refactor should probably not be done in this PR, so I propose leaving ownState
as JsonObject
for now.
@zhaoyongjie and @villebro, Any news on this? It would be great to have this implemented. |
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:
If you need help with the migration, please post a message on the SIP or reach out on the community Slack. |
🏆 Enhancements
Draft Drilldown POC