-
Notifications
You must be signed in to change notification settings - Fork 272
feat(core): add support for non-temporal series limit #1356
feat(core): add support for non-temporal series limit #1356
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2gx3XZ76mr7RdZb7C12VLrfc3vfr |
a23ed3d
to
8c7b54e
Compare
8c7b54e
to
1331d43
Compare
1331d43
to
83c563e
Compare
83c563e
to
bb2f797
Compare
bb2f797
to
4cb0260
Compare
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
==========================================
+ Coverage 30.03% 30.05% +0.01%
==========================================
Files 489 489
Lines 9854 9859 +5
Branches 1654 1657 +3
==========================================
+ Hits 2960 2963 +3
Misses 6653 6653
- Partials 241 243 +2
Continue to review full report at Codecov.
|
Co-authored-by: Michael S. Molina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks all for the input and reviews! Looking forward to help make generic x-axis happen! |
🏆 Enhancements
Currently it is impossible to restrict the number of series in non-temporal charts. This adds three new
QueryForm
andQueryObject
properties, along with relevant shared controls for them:series_columns
: the columns to group by when limiting series (previously always assumed to be all groupby columns except the temporal column). This can be leftundefined
/[]
, in which case series limiting won't happen.series_limit
: to replacetimeseries_limit
series_limit_metric
: to replacetimeseries_limit_metric
As a POC, this functionality is implemented on the BoxPlot chart where this functionality was mostly broken (only working if distribution was across temporal column).
Related PR on
apache/superset
: apache/superset#16660AFTER
Here we've defined a non-temporal series limit column
countries
with a limit of 5 series, and the chart renders correctly with the top 5 regions:BEFORE
Before the x-axis would populate more than the specified 5 series: