-
Notifications
You must be signed in to change notification settings - Fork 272
chore(legacy-chart-nvd3): convert nvd3 to emotion style #692
chore(legacy-chart-nvd3): convert nvd3 to emotion style #692
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/kko1509vi |
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 24.04% 24.15% +0.10%
==========================================
Files 338 339 +1
Lines 7590 7631 +41
Branches 918 926 +8
==========================================
+ Hits 1825 1843 +18
- Misses 5692 5715 +23
Partials 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think there's some duplicate code here.
💔 Breaking Changes
🏆 Enhancements
![0 Superset Security](https://user-images.githubusercontent.com/17326228/87988050-84311080-ca94-11ea-8039-ebfa74e4a4ca.png)
before


after
![image](https://user-images.githubusercontent.com/17326228/87988267-e722a780-ca94-11ea-9ab6-59c194890126.png)
![image](https://user-images.githubusercontent.com/17326228/87988391-189b7300-ca95-11ea-888d-c4b13d54642d.png)
![image](https://user-images.githubusercontent.com/17326228/87988408-1df8bd80-ca95-11ea-94b0-b5ec571dc116.png)
![image](https://user-images.githubusercontent.com/17326228/87988415-23560800-ca95-11ea-93b3-41036244dcb4.png)
![image](https://user-images.githubusercontent.com/17326228/87988427-27822580-ca95-11ea-91de-4db9d6d36724.png)
![image](https://user-images.githubusercontent.com/17326228/87988439-2bae4300-ca95-11ea-856e-0ab8ee45624b.png)






📜 Documentation
🐛 Bug Fix
🏠 Internal