Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: support multi queries request #846

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Dec 1, 2020

🏆 Enhancements

Gives opportunity to get multi queries response results from incubator:
See PR: https://github.com/apache/incubator-superset/pull/11880/files

@simcha90 simcha90 requested a review from a team as a code owner December 1, 2020 18:37
@vercel
Copy link

vercel bot commented Dec 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/kvz62ajf7
✅ Preview: https://superset-ui-git-multi-queries.superset.now.sh

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #846 (4eb61f4) into master (ef82336) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
+ Coverage   26.44%   26.59%   +0.15%     
==========================================
  Files         365      377      +12     
  Lines        8066     8170     +104     
  Branches     1093     1119      +26     
==========================================
+ Hits         2133     2173      +40     
- Misses       5805     5869      +64     
  Partials      128      128              
Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <100.00%> (ø)
...es/superset-ui-core/src/chart/models/ChartProps.ts 100.00% <100.00%> (ø)
...kages/superset-ui-core/src/query/processFilters.ts 100.00% <0.00%> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <0.00%> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <0.00%> (ø)
...superset-ui-core/src/chart/models/ChartMetadata.ts 100.00% <0.00%> (ø)
...ugins/plugin-filter-antd/src/Range/controlPanel.ts 100.00% <0.00%> (ø)
...plugin-filter-antd/src/Select/AntdSelectFilter.tsx 0.00% <0.00%> (ø)
...ins/plugin-filter-antd/src/Range/transformProps.ts 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef82336...4eb61f4. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about adding a note about deprecation of queryData, other than that LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants