Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scan consistency IT so that it can also be run standalone #3646

Open
keith-turner opened this issue Jul 21, 2023 · 4 comments · May be fixed by #4051
Open

Refactor scan consistency IT so that it can also be run standalone #3646

keith-turner opened this issue Jul 21, 2023 · 4 comments · May be fixed by #4051
Assignees
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@keith-turner
Copy link
Contributor

Running the scan consistency test added in #3639 standalone for longer periods would be useful to stress test accumulo. The test could be refactored to support this by adding a main method that takes an accumulo properties file and runs the test. This would allow running against a standalone instance for long periods of time where its easier to inspect different parts of accumulo.

@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label Jul 21, 2023
@DomGarguilo
Copy link
Member

As a long running test, would this be more fitting to move to AccumuloTesting? Or do you think it should stay here?

@keith-turner
Copy link
Contributor Author

keith-turner commented Jul 21, 2023

As a long running test, would this be more fitting to move to AccumuloTesting? Or do you think it should stay here?

I think its nice to have as an IT that stresses a lot of functionality together that's always expected to work (that is why I added it as a sunny day test). So I think its nice to leave it here.

@ctubbsii
Copy link
Member

ctubbsii commented Aug 2, 2023

As a long running test, would this be more fitting to move to AccumuloTesting? Or do you think it should stay here?

I think its nice to have as an IT that stresses a lot of functionality together that's always expected to work (that is why I added it as a sunny day test). So I think its nice to leave it here.

I think the point of the sunny day test suite is that they test base functionality, and is something that gives us a quick "yes" or "no" on mergability for any particular patch or contribution. If one of those tests fails, it means Accumulo stopped doing basic things, like starting up, or communicating between server types. These are tests we expect a contributor to have not broken, and should be fast enough to run the whole batch of them on a modest developer hardware, like a contributor's personal laptop. I don't think we should be putting stress tests in there, or edge case coverage, or anything that is nondeterministic or flaky. Of those, I'd consider this test "edge case coverage", and don't think it warrants making sunny take longer to execute. But, I think it's fine to leave here, rather than move it to the testing repo.

@kevinrr888
Copy link
Member

I will work on this ticket

kevinrr888 added a commit to kevinrr888/accumulo that referenced this issue Dec 11, 2023
Closes apache#3646. Refactored ScanConsistencyIT to be able to be run standalone. Can now be run as a test or from main.
@kevinrr888 kevinrr888 linked a pull request Dec 11, 2023 that will close this issue
@DomGarguilo DomGarguilo added this to the 3.1.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants