You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
MultipleStoresIT should be refactored to function more similarly to how other Fate tests are run (e.g., FateIT) where the two stores are tested in their own separate concrete classes. The existing tests use FateTestRunner, but that doesn't work as nicely here since those function under the assumption of one of each store type, which is not the case with this new test.
Describe the solution you'd like
MultipleStoresIT to be an abstract class implemented by two new classes: UserMultipleStoresIT and MetaMultipleStoresIT, and a new interface similar to how FateTestRunner is currently used.
Describe alternatives you've considered
The current impl is another alternative, which works but isn't as nice as the above suggestion: it isn't consistent with the structure of the existing Fate tests, and consider this in the current impl:
@Test
public void testReserveUnreserve() throws Exception {
testReserveUnreserve(FateInstanceType.META);
testReserveUnreserve(FateInstanceType.USER);
}
If the first call fails, USER will not be run. Would be nicer to have both run irrespective of order and failures.
Refactors MultipleStoresIT to function more similarly to how other fate
tests are run (the two store types are tested in their own separate
concrete classes). Created MultipleStoresTestRunner which is very
similar to FateTestRunner. MultipleStoresIT is now an abstract class
implemented by two new classes MetaMultipleStoresIT and
UserMultipleStoresIT.
closesapache#4903
* Refactors MultipleStoresIT
Refactors MultipleStoresIT to function more similarly to how other fate
tests are run (the two store types are tested in their own separate
concrete classes). MultipleStoresIT is now an abstract class
implemented by two new classes MetaMultipleStoresIT and
UserMultipleStoresIT.
closes#4903
Is your feature request related to a problem? Please describe.
MultipleStoresIT should be refactored to function more similarly to how other Fate tests are run (e.g., FateIT) where the two stores are tested in their own separate concrete classes. The existing tests use FateTestRunner, but that doesn't work as nicely here since those function under the assumption of one of each store type, which is not the case with this new test.
Describe the solution you'd like
MultipleStoresIT to be an abstract class implemented by two new classes: UserMultipleStoresIT and MetaMultipleStoresIT, and a new interface similar to how FateTestRunner is currently used.
Describe alternatives you've considered
The current impl is another alternative, which works but isn't as nice as the above suggestion: it isn't consistent with the structure of the existing Fate tests, and consider this in the current impl:
If the first call fails, USER will not be run. Would be nicer to have both run irrespective of order and failures.
Additional context
See comment #4524 (comment)
See changes from #4524
The text was updated successfully, but these errors were encountered: