Moved automatic splits to the manager #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
May 8, 2023
| @@ -1273,6 +1323,10 @@ boolean canSuspendTablets() { | |||
| throw new IllegalStateException("Exception updating manager lock", e); | |||
| } | |||
|
|
|||
| // TODO shut this down later? Is this the correct place to start this? | |||
| this.splitter = new Splitter(context, DataLevel.USER, this); | |||
There was a problem hiding this comment.
Is there a reason not to make this part of the TabletGroupWatcher?
There was a problem hiding this comment.
Not that I know of, I did not start there because I was unsure if that was the best path and I wanted to get some basic functionality working. I think that would be a good follow on issue to explore.
The Manager now scans tablets looking for ones that need to split. When it finds one it queues it on a thread pool for inspection of files to find a split point. When split points are found a FATE operation is initiated to do the splits. The FATE operation uses conditional mutations to syncronize access to the tablet metadata. The FATE operation creates one or more new tablets in the metadata table. Unlike the the old split code which could only split a tablet into two, this new code can split a tablet into however many are needed in a single operation. This makes responding to a change in the split threshold much faster. The old code used to shorten split points, this change carries that behavior forward in the new code to find multiple split points. This change does not include moving user intiated splits into the manager, that will be done in a follow on change.
keith-turner
force-pushed
the
splitting-in-manager3
branch
from
788321a to
7bdef27
Compare
keith-turner
changed the title
This was referenced May 18, 2023
This was referenced May 25, 2023
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took this out of draft. The following the message from the commit.