catches exceptions and logs when planning compactions #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Apr 8, 2024
| String cacheKey = tablet.getTableId() + " " + e.getClass().getName(); | ||
| // This check defends against every tablet in a table having the same problem and therefore | ||
| // generating an enormous amount of spam for the logs. | ||
| var last = generateJobsErrorCache.getIfPresent(cacheKey); |
There was a problem hiding this comment.
I think you might be able to just call Cache.get(Key,Function) here and last will be null if it doesn't exist.
Suggested change
| var last = generateJobsErrorCache.getIfPresent(cacheKey); | |
| if (generateJobsErrorCache.get(cacheKey, () -> System.currentTimeMillis) == null) { |
There was a problem hiding this comment.
Looking at the docs for get it will return the computed value if absent. Can get the prev value w/ putIfAbsent. Made that change in d246ee8
| "Failed to generate compaction jobs for {}. Other tablets may be experiencing the" | ||
| + " same error, this log message is temporarily suppressed for the entire table.", | ||
| tablet.getExtent(), e); | ||
| generateJobsErrorCache.put(cacheKey, System.currentTimeMillis()); |
There was a problem hiding this comment.
Remove this if you apply my suggestion above.
Suggested change
| generateJobsErrorCache.put(cacheKey, System.currentTimeMillis()); |
dlmarion
approved these changes
May 28, 2024
|
Closing in favor of #4586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.