Cleanup of main branch #4747
Merged
Cleanup of main branch #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove log4j-1.2-api dependency except as a bridge in the binary assembly (left a note in the assemble/pom.xml) * Move log4j dependencies in core back to test scope. These were moved to the provided scope in apache#4743 to work around an issue because log4j-1.2-api was still used in the core module in 2.1; now that the legacy log4j stuff was removed from core in 3.1 and later, we can move these back to the test scope where they belong as apache#4558 intended * Specify the exact version for deprecation "since" parameters (3.1.0, instead of 3.1) * Drop the unused and deprecated `tserver.workq.threads` property * Remove a few unused imports and variables, and drop the legacy MeterRegistryFactory that was deprecated in 2.1.3 * Suppress some deprecation warnings and use var in a few places for readability * Delete unused test code in CompactionIT
keith-turner
approved these changes
Jul 22, 2024
| import org.apache.hadoop.io.Text; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class ColumnVisibilityTest { | ||
|
|
||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Seeing these changes made me realize that maybe we could start removing some of the stuff that was deprecated re ColumnVisibility in 4.0.0.
Add legacy log4j API back as test dependency for hadoop minicluster, which fixes HadoopCredentialProviderTest
|
It looks like we still need log4j-1.2-api on the classpath for hadoop minicluster's runtime. So, I'll have to re-add that back in for any tests or mini accumulo that use it before this can be merged. |
Re-add log4j-1.2-api dependency in the proper scopes, as a required runtime dependency of hadoop-client-minicluster
|
It looks like I fixed all the issues with the dependencies, so I'll merge this now. |
ctubbsii
pushed a commit
to apache/accumulo-testing
that referenced
this pull request
Aug 7, 2024
Remove the property usage because it was removed in apache/accumulo#4747 This fixes #280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tserver.workq.threadsproperty