ARTEMIS-5100 support journal-max-io on 'create' CLI command #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -327,6 +327,9 @@ public String[] getStaticNodes() { | |||
| @Option(names = "--jdbc-lock-expiration", description = "Lock expiration (in milliseconds).") | |||
| long jdbcLockExpiration = ActiveMQDefaultConfiguration.getDefaultJdbcLockExpirationMillis(); | |||
|
|
|||
| @Option(names = "--aio-journal-max-io", description = "The journal-max-io value to use when also using the ASYNCIO journal-type. When using NIO or MAPPED this value is always '1'. Default: 4096") | |||
There was a problem hiding this comment.
what about --journal-max-aio?
(journal max asynchronous io).
jbertram
force-pushed
the
ARTEMIS-5100
branch
from
ae87d60 to
da89995
Compare
jbertram
force-pushed
the
ARTEMIS-5100
branch
from
da89995 to
3573581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled to decide the name of the input, ultimately settling on
--aio-journal-max-ioto clarify that it only applies tojournal-max-iowhen using aio.