Fix json serialization error in Python Driver (#1228) (#1598)

* * Added test to catch the error in toJson() * removed the trailing comma in _nodeToJson() node.properties part * removed the trailing comma in _nodeToString() node.properties part * * Added missing ", ".join() _nodeToString() in node.properties part --------- Co-authored-by: Olivier <[email protected]> Resolved - Conflicts: drivers/python/test_age_py.py Co-authored-by: omaurel-socha <[email protected]>
apache · Feb 14, 2024 · 0273d47 · 0273d47
1 parent 0584de0
commit 0273d47
Show file tree

Hide file tree

Showing 2 changed files with 429 additions and 379 deletions.
diff --git a/drivers/python/age/models.py b/drivers/python/age/models.py
@@ -238,11 +238,12 @@ def _nodeToString(node, buf, extraFormatter=None):
 
     if node.properties != None:
         buf.write(", properties:{")
-        for k,v in node.properties.items():
-            buf.write(k)
-            buf.write(": ")
-            buf.write(str(v))
-            buf.write(", ")
+        prop_list = []
+        for k, v in node.properties.items():
+            prop_list.append(f"{k}: {str(v)}")
+
+        # Join properties with comma and write to buffer
+        buf.write(", ".join(prop_list))
         buf.write("}")
 
     if extraFormatter != None:
@@ -281,12 +282,13 @@ def _nodeToJson(node, buf, extraFormatter=None):
 
     if node.properties != None:
         buf.write(", \"properties\":{")
-        for k,v in node.properties.items():
-            buf.write("\"")
-            buf.write(k)
-            buf.write("\": \"")
-            buf.write(str(v))
-            buf.write("\", ")
+
+        prop_list = []
+        for k, v in node.properties.items():
+            prop_list.append(f"\"{k}\": \"{str(v)}\"")
+
+        # Join properties with comma and write to buffer
+        buf.write(", ".join(prop_list))
         buf.write("}")
     buf.write("}")