Fix error using list comprehension with WITH * #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a check for the case where the list comprehension is used with `WITH *`. Handled this case by adding entries in targetlist to the group clause. - Added regression tests.
MuhammadTahaNaveed
force-pushed
the
list_comp_i1
branch
from
2edef10 to
d4835a9
Compare
jrgemignani
approved these changes
May 7, 2024
MuhammadTahaNaveed
added a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
May 9, 2024
- Added a check for the case where the list comprehension is used with `WITH *`. Handled this case by adding entries in targetlist to the group clause. - Added regression tests.
MuhammadTahaNaveed
added a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
May 9, 2024
- Added a check for the case where the list comprehension is used with `WITH *`. Handled this case by adding entries in targetlist to the group clause. - Added regression tests.
MuhammadTahaNaveed
added a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
May 9, 2024
- Added a check for the case where the list comprehension is used with `WITH *`. Handled this case by adding entries in targetlist to the group clause. - Added regression tests.
MuhammadTahaNaveed
added a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
May 9, 2024
- Added a check for the case where the list comprehension is used with `WITH *`. Handled this case by adding entries in targetlist to the group clause. - Added regression tests.
jrgemignani
pushed a commit
that referenced
this pull request
May 9, 2024
jrgemignani
pushed a commit
that referenced
this pull request
May 9, 2024
jrgemignani
pushed a commit
that referenced
this pull request
May 9, 2024
jrgemignani
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for the case where the list comprehension is used with
WITH *. Handled this case by adding entries in targetlist to the group clause.Added regression tests.